you'd be most or less correct .. a bit vague but somewhat correct
agility is also really nice on a warrior
str is great for dps, the more AP the better
agi is good for dps, and also good for tanking for the extra dodge/armor
stamina is always good for anything, whether it be tanking, dpsing or pvping your gonna always need stamina