aaahhhh im horrible at making choices and i need other peoples advice ......... i was thinking engineering/ mine but i have no clue smithing sounds like no fun idk help me out here
Any tradeskill for Shaman works out well, except maybe tailoring or blacksmithing.
I think leatherworking/skinning for mail armor post 40 is good. I took Herb/Alch so I could always have potions ready and sell some too. Mining/Engineering is always a good choice as as it adds lots of trinkets and items.