I'm a armorsmith on my warrior and I just make the Imperial plate set and put it in the AH or I either make a Enchanted Thorium Piece and they usually sell for 350g +. If your looking to gain money you have to have the money to buy the mats and some of the mats for weaponsmithing is very lot but if you have the money weaponsmithing probably makes about 600+ gold with the weapons you make. Really armorsmithing has really good peices for tanking, Valor isn't that great for tanking just some good pieces in valor but what ever you do i believe you make the same amount of money from them